Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve file paths in remote config #3002

Merged
merged 7 commits into from
Jan 1, 2025
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 1, 2025

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Custom sql_paths in remotes block is not resolved properly.

What is the new behavior?

Refactor path resolution to be called for each remote.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 1, 2025 06:05
@coveralls
Copy link

coveralls commented Jan 1, 2025

Pull Request Test Coverage Report for Build 12569661772

Details

  • 28 of 40 (70.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 59.758%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/config.go 28 40 70.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12552570503: 0.01%
Covered Lines: 7661
Relevant Lines: 12820

💛 - Coveralls

@sweatybridge sweatybridge merged commit 7a513e3 into develop Jan 1, 2025
9 checks passed
@sweatybridge sweatybridge deleted the sweatybridge-patch-1 branch January 1, 2025 13:10
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants